Re: [patch 2.6.12-rc3] dell_rbu: Resubmitting patch for new Dell BIOS update driver

From: Greg KH
Date: Thu May 19 2005 - 09:42:38 EST


On Thu, May 19, 2005 at 07:03:17AM -0500, Abhay_Salunke@xxxxxxxx wrote:
> > On Wed, May 18, 2005 at 01:13:42PM -0500, Abhay Salunke wrote:
> > > This is a resubmit of the patch after incorporating all the inputs
> > > from revieweres. This also has a fix where the packets were leaked in
> > > the function create_packet line#227.
> >
> > You did not address the issues I had with your use of binary sysfs files
> > for all file types. Please fix that up.
> >
> > Also, what's wrong with using the existing firmware interface in the
> > kernel?
> >
> I am working on it; just wanted to address all the cosmetic issues
> first.

That is not what you stated above, hence my response. Next time, please
be clearer.

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/