Re: [PATCH 2/3] Dynamic sched domains (v0.6)

[Nick Piggin]

Dinakar Guniguntala wrote:
> o Patch2 has updated cpusets documentation and the core update_cpu_domains
>   function
> o I have also moved the dentry d_lock as discussed previously

Hi Dinakar,
patch1 looks good. Just one tiny little minor thing:

> +
> +	lock_cpu_hotplug();
> +	partition_sched_domains(&pspan, &cspan);
> +	unlock_cpu_hotplug();
> +}
> +

I don't think the cpu hotplug lock isn't supposed to provide
synchronisation between readers (for example, it may be turned
into an rwsem), but only between the thread and the cpu hotplug
callbacks.

In that case, can you move this locking into kernel/sched.c, and
add the comment in partition_sched_domains that the callers must
take care of synchronisation (which without reading the code, I
assume you're doing with the cpuset sem?).

If you agree with that change, you can add an
Acked-by: Nick Piggin <nickpiggin@xxxxxxxxxxxx>
to patch 1 and send it to Andrew whenever you're ready (better
CC Ingo as well). If not, please discuss! :)

Thanks,
Nick

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/