Re: [PATCH 2.6.12-rc4-mm1 3/4] megaraid_sas: updating the driver

[Arjan van de Ven]

> +
> +		if (exception) {
> +	
> +			spin_lock( instance->host_lock );
> +			cmd->scmd->scsi_done( cmd->scmd );
> +			spin_unlock( instance->host_lock );

are you really sure you don't want to use spin_lock_irqsave() here ?

> +	unregister_chrdev( megasas_mgmt_majorno, "megaraid_sas_ioctl" );

I really don't like this idea of weird ioctl devices though...


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/