Re: [patch] mm: fix rss counter being incremented when unmapping

[Christoph Lameter]

Correct. Thanks for catching that. My latest rss patch also has that.

On Mon, 9 May 2005, Björn Steinbrink wrote:

> This patch fixes a bug introduced by the "mm counter operations through
> macros" patch, which replaced a decrement operation in with an increment
> macro in try_to_unmap_one().
>
> Signed-off-by: Björn Steinbrink <B.Steinbrink@xxxxxx>
>
> diff -NurpP --minimal linux-2.6.12-rc4/mm/rmap.c linux-2.6.12-rc4-fixed/mm/rmap.c
> --- linux-2.6.12-rc4/mm/rmap.c  2005-05-08 17:53:49.000000000 +0200
> +++ linux-2.6.12-rc4-fixed/mm/rmap.c    2005-05-09 13:38:03.000000000 +0200
> @@ -586,7 +586,7 @@ static int try_to_unmap_one(struct page
>                 dec_mm_counter(mm, anon_rss);
>         }
>
> -       inc_mm_counter(mm, rss);
> +       dec_mm_counter(mm, rss);
>         page_remove_rmap(page);
>         page_cache_release(page);
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@xxxxxxxxxx  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"aart@xxxxxxxxx";> aart@xxxxxxxxx </a>
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/