Re: [PATCH][4/4] let's kill verify_area - convert kernel/printk.c to access_ok()

[Vincent Hanquez]

On Fri, Jan 07, 2005 at 02:18:55AM +0100, Jesper Juhl wrote:
> @@ -300,8 +300,8 @@ int do_syslog(int type, char __user * bu
>  		error = 0;
>  		if (!len)
>  			goto out;
> -		error = verify_area(VERIFY_WRITE,buf,len);
> -		if (error)
> +		error = access_ok(VERIFY_WRITE,buf,len);
> +		if (!error)

I would rather put the ! on access_ok
"if (!error)" is read as "if no error"

-- 
Vincent Hanquez
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/