Re: [PATCH] fs: Restore files_lock and set_fs_root exports

From: Arjan van de Ven
Date: Fri Jan 07 2005 - 02:43:04 EST


On Thu, 2005-01-06 at 16:24 -0800, Linus Torvalds wrote:
>
> On Thu, 6 Jan 2005, Alan Cox wrote:
>
> > On Iau, 2005-01-06 at 23:26, Andrew Morton wrote:
> > > I think the exports should be restored. So does Linus ("Not that I like it
> > > all that much, but I don't think we should break existing modules unless we
> > > have a very specific reason to break just those modules.").
> >
> > What happens when the feature is just not (ab)usable in the way proposed ?
>
> At that point there is a specific _reason_ to break it, aka "that function
> simply doesn't exist any more".

how about "it can be static, and static functions without external
references can be better optimized by gcc (and are, as of version 3.4)"
(where function pointers are seen as external references, and
EXPORT_SYMBOL does just that)


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/