Re: [PATCH][RFC] clean out old cruft from FD MCS driver

[Jesper Juhl]

On Tue, 4 Jan 2005, Matthew Wilcox wrote:

> On Tue, Jan 04, 2005 at 12:11:27AM +0100, Jesper Juhl wrote:
> > At this point I got the feeling that this driver had been left to rot and 
> > I desided to see if there was more cruft in there that we might as well 
> > get rid of, and indeed there is.
> 
> Yup.  There's a lot of cruft in that driver.  I really don't like the
> look of fd_mcs_intr() -- trying to deduce whether or not there's a data phase
> out based on the command byte?  urgh.
> 
> There's a somehat better-maintained driver -- fdomain.c.  It'd be great
> if someone could make fdomain.c support the MCA cards -- and even the PCMCIA
> cards without having the separate fdomain_stub.c.

That would be even better, but until that happens why not apply the patch 
I submitted (assuming it is actually OK) in its current form? That at 
least would clean out some of the cruft (and kill a warning) so there's 
less to sift through for someone reading the driver later.

-- 
Jesper


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/