Re: [PATCH][RFC] clean out old cruft from FD MCS driver

From: Matthew Wilcox
Date: Mon Jan 03 2005 - 22:09:09 EST


On Tue, Jan 04, 2005 at 12:11:27AM +0100, Jesper Juhl wrote:
> At this point I got the feeling that this driver had been left to rot and
> I desided to see if there was more cruft in there that we might as well
> get rid of, and indeed there is.

Yup. There's a lot of cruft in that driver. I really don't like the
look of fd_mcs_intr() -- trying to deduce whether or not there's a data phase
out based on the command byte? urgh.

There's a somehat better-maintained driver -- fdomain.c. It'd be great
if someone could make fdomain.c support the MCA cards -- and even the PCMCIA
cards without having the separate fdomain_stub.c. I'd be happy to make
suggestions to anyone who has an fdomain card and wants to take on the
responsibility of maintaining the driver.

If anyone's really keen, there's an ISA card on eBay for $2 ...
http://cgi.ebay.com/ws/eBayISAPI.dll?ViewItem&item=5152656129

--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/