Re: [3/8] kill gen_init_cpio.c printk() of size_t warning

[linux-os]

On Mon, 3 Jan 2005, William Lee Irwin III wrote:

> On Mon, Jan 03, 2005 at 12:59:55PM -0500, Jeff Garzik wrote:
> > This removes whitespace in the process, violating the file's chosen
> > style (and typical lkml style).
>
> I have no personal interest in the whitespace involved. The following
> amended patch is likely to avoid inconsistencies with the rest of the
> file regarding whitespace.
>
>
> -- wli

But it's wrong.
It should be:
> +		strlen(target) + 1U,	/* filesize */

strlen() already returns a size_t. You need an unsigned 1 to
not affect it. As previously stated, an integer constant
is an int, not an unsigned int unless you make it so with
"U".

> Index: mm1-2.6.10/usr/gen_init_cpio.c
> ===================================================================
> --- mm1-2.6.10.orig/usr/gen_init_cpio.c	2005-01-03 06:45:53.000000000 -0800
> +++ mm1-2.6.10/usr/gen_init_cpio.c	2005-01-03 09:42:18.000000000 -0800
> @@ -112,7 +112,7 @@
> 		(long) gid,		/* gid */
> 		1,			/* nlink */
> 		(long) mtime,		/* mtime */
> -		strlen(target) + 1,	/* filesize */
> +		(unsigned)strlen(target) + 1,/* filesize */
> 		3,			/* major */
> 		1,			/* minor */
> 		0,			/* rmajor */
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Cheers,
Dick Johnson
Penguin : Linux version 2.6.9 on an i686 machine (5537.79 BogoMips).
 Notice : All mail here is now cached for review by Dictator Bush.
                 98.36% of all statistics are fiction.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/