Re: [pktcdvd] Badness in fork.c:91 then Oops

[Mateusz . Blaszczyk]

> Mateusz.Blaszczyk@xxxxxxx writes:
>
> > PKTCDVD seems to create some badness in kernel/fork, line 91:
> >
> > I loaded pktcdvd manaully end everything was fine
> >
> > Dec 30 08:32:46 localhost kernel: pktcdvd: v0.2.0a 2004-07-14 Jens Axboe (axboe@xxxxxxx) and petero2@xxxxxxxxx
> >
> > Then I tried to map cd drive using udftools' pktsetup (v.1.0.3b):
> >
> > Dec 30 08:33:27 localhost kernel: cdrom: This disc doesn't have any tracks I recognize!
> > Dec 30 08:33:27 localhost kernel: Badness in __put_task_struct at kernel/fork.c:91
> ...
> > Dec 30 08:05:52 localhost kernel: Software Suspend Core.
> > Dec 30 08:05:52 localhost kernel: Software Suspend text mode support loaded.
> > Dec 30 08:05:52 localhost kernel: Software Suspend LZF Compression Driver registered.
> > Dec 30 08:05:52 localhost kernel: Software Suspend Swap Writer registered.
>
> It's actually the swsusp 2 patches that don't handle the pktcdvd
> driver correctly. The kthread_run() function was changed, but the
> pktcdvd driver wasn't updated accordingly. I think this patch will fix
> the problem.
>
> --- linux/drivers/block/pktcdvd.c.old	2004-12-30 20:11:54.400478672 +0100
> +++ linux/drivers/block/pktcdvd.c	2004-12-30 20:12:09.617165384 +0100
> @@ -2364,7 +2364,7 @@
>  	pkt_init_queue(pd);
>
>  	atomic_set(&pd->cdrw.pending_bios, 0);
> -	pd->cdrw.thread = kthread_run(kcdrwd, pd, "%s", pd->name);
> +	pd->cdrw.thread = kthread_run(kcdrwd, pd, PF_SYNCTHREAD, "%s", pd->name);
>  	if (IS_ERR(pd->cdrw.thread)) {
>  		printk("pktcdvd: can't start kernel thread\n");
>  		ret = -ENOMEM;
>

Thank you , it works now.


-mat

-- 
Pozdrowienia,Regards,Cheers,Grüße,A plus!,
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/