Re: [PATCH][1/2] fix unchecked returns from kmalloc() (inkernel/module.c)

From: Rusty Russell
Date: Tue Dec 07 2004 - 23:34:54 EST


On Tue, 2004-12-07 at 22:23 +0100, Jesper Juhl wrote:
> Problem reported by Katrina Tsipenyuk and the Fortify Software engineering
> team in thread with subject "PROBLEM: unchecked returns from kmalloc() in
> linux-2.6.10-rc2".

IMHO a better fix is to
(1) mark percpu_modinit() as __init.
(2) ignore unhandled failures in __init functions.

With some exceptions, I would prefer to see a not_on_init(cond) macro
inside kmalloc et. al. which barfs in a consistent way when allocations,
registrations, etc. fail on boot.

Rusty.
--
A bad analogy is like a leaky screwdriver -- Richard Braakman

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/