Re: realtek r8169 + kernel 2.4.24 (openmosix)

From: Francois Romieu
Date: Sun Dec 05 2004 - 07:28:09 EST


Nicholas Papadakos <panic@xxxxxxxx> :
[...]
> I commented out the line recompiled but still same problem.

gcc should spit one message less.

> I tried to apply the patch both in the older version and in the new one but
> nothing.

The tabs have been turned into spaces. Either add 'ull' to 0x0badbadbadbadbad
or apply the attached version (don't edit/copy/paste it if you are not sure
that the tabs are preserved).

[...]
> And yeah values greater than 1500 would improve openmosix a lot a believe.

A backport of the test version of the 2.6.x driver (SG, RX/TX csum, up to ~7000
bytes frames, patch against vanilla 2.4.28) is available at:
http://www.fr.zoreil.com/people/francois/misc/20041205-2.4.28-r8169.c-test.patch

For the curious one, the patchscript version can be found at:
http://www.fr.zoreil.com/linux/kernel/2.4.x/2.4.28

It compiles but it is completely untested. You should probably wait a bit until
I verify it is not trivially broken. Otoh, if you have some spare time...

--
Ueimor
--- drivers/net/r8169.c.orig 2004-12-04 18:22:18.000000000 +0100
+++ drivers/net/r8169.c 2004-12-04 18:22:37.000000000 +0100
@@ -1161,7 +1161,7 @@ rtl8169_hw_start(struct net_device *dev)

static inline void rtl8169_make_unusable_by_asic(struct RxDesc *desc)
{
- desc->addr = 0x0badbadbadbadbad;
+ desc->addr = 0x0badbadbadbadbadull;
desc->status &= ~cpu_to_le32(OWNbit | RsvdMask);
}