Re: [0/3] PATCH Kprobes for x86_64- 2.6.9-final

[Andi Kleen]

On Thu, Oct 28, 2004 at 09:23:59PM +0530, Prasanna S Panchamukhi wrote:
> 
> On Thu, Oct 28, 2004 at 01:37:44PM +0200, Andi Kleen wrote:
> > 
> > Like I still would like to have the page fault notifier
> > completely moved out of the fast path into no_context 
> > (that i386 has it there is also wrong). Adding kprobe_runn 
> > doesn't make a difference.
> 
>     The kprobes fault handler is called if an exception is 
> generated for any instruction within the fault-handler or when 
> Kprobes single-steps the probed instruction.
> AFAIK kprobes does not handle page faults in the above case and just returns
> immediately resuming the normal execution. 

Ok. It's ugly, but ok. Can you remove the bogus kprobes_running()
then please, it's unnecessary?  

With that change it would be ok to merge from my side.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/