Re: [PATCH] pmac_cpufreq msleep cleanup/fixes

[Linus Torvalds]

On Sat, 23 Oct 2004, Benjamin Herrenschmidt wrote:
> 
> Please revert that change until we have made absolutely sure that msleep(1)
> on a HZ=1000 machine will actually sleep at least 1ms, this is really not
> clear since it will end up doing schedule_timeout(1) which, afaik, will
> only guarantee to sleep up to the next jiffie, which can be a lot shorter
> than the actual duration of a jiffie.

In that case I'd much prefer to revert the whole previous "cleanup" as 
well, since it obviously isn't really. Having

	msleep(1 + jiffy_to_ms(1));

is just not a cleanup to me.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/