Re: [PATCH] pmac_cpufreq msleep cleanup/fixes

[Benjamin Herrenschmidt]

On Sat, 2004-10-23 at 04:11, Linux Kernel Mailing List wrote:
> ChangeSet 1.2015, 2004/10/22 11:11:36-07:00, nacc@xxxxxxxxxx
> 
> 	[PATCH] pmac_cpufreq msleep cleanup/fixes
> 	
> 	Uses msleep() instead of schedule_timeout() to guarantee the task delays
> 	as expected.  Two of the changes are reworks of previous msleep() calls
> 	which unnecessarily added a jiffy to the parameter.
> 	
> 	Signed-off-by: Nishanth Aravamudan <nacc@xxxxxxxxxx>
> 	Signed-off-by: Linus Torvalds <torvalds@xxxxxxxx>

Please revert that change until we have made absolutely sure that msleep(1)
on a HZ=1000 machine will actually sleep at least 1ms, this is really not
clear since it will end up doing schedule_timeout(1) which, afaik, will
only guarantee to sleep up to the next jiffie, which can be a lot shorter
than the actual duration of a jiffie.

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/