Re: [PATCH 2.4.28-pre4-bk6] delkin_cb: new driver for Cardbus IDECF adaptor

[Mark Lord]

Bartlomiej Zolnierkiewicz wrote:
> wrt to 2.6.x version
..
> please use ide_std_init_ports()

Okay, will do.

> > +       rc = ide_register_hw(&hw, &hwif);
> > +       if (rc < 0)     /* ide_register_hw likes to be invoked twice (buggy) */
> > +               rc = ide_register_hw(&hw, &hwif);
>
> is this needed in 2.6.x and if so why?

Not sure yet -- still testing, though I've already done an #if 0 on it.

> > +               drive->id->csfo = 0; /* workaround for idedisk_open bug */

Not there in the 2.6.xx version.

And in 2.4.xx.. why is idedisk_open() examining vendor-specific
fields of the IDENTIFY data, anyway?  Very very unsafe.
I put the above one-liner workaround (drive->id->csfo) into delkin_cb
to bypass the problems it creates for now, until idedisk_open gets fixed.

Normally I'd just send a patch to fix idedisk_open(), but since I don't
even understand what it is trying to do, it would be safer for whoever
put that code there to have a second look.  Especially since 2.4.xx
is supposed to be stable now -- if it ain't broke, don't break it.  :)

Cheers
--
Mark Lord
(hdparm keeper & the original "Linux IDE Guy")
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/