Re: [PATCH 2.4.28-pre4-bk6] delkin_cb: new driver for Cardbus IDE CF adaptor

[Bartlomiej Zolnierkiewicz]

wrt to 2.6.x version

> +       memset(&hw, 0, sizeof(hw));
> +       ide_init_hwif_ports(&hw, (ide_ioreg_t)(base + 0x10),
> +                                (ide_ioreg_t)(base + 0x1e), NULL);

please use ide_std_init_ports()

> +       rc = ide_register_hw(&hw, &hwif);
> +       if (rc < 0)     /* ide_register_hw likes to be invoked twice (buggy) */
> +               rc = ide_register_hw(&hw, &hwif);

is this needed in 2.6.x and if so why?

> +               drive->id->csfo = 0; /* workaround for idedisk_open bug */

ditto
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/