Re: [KJ] [RFT 2.6] intel-agp.c: replace pci_find_device with pci_get_device

[Dave Jones]

On Wed, Oct 20, 2004 at 11:06:38PM +0100, Christoph Hellwig wrote:

 > > > As pci_find_device is going away soon I have converted this file to use
 > > > pci_get_device instead. I have compile tested it. If anyone has this hardware
 > > > and could test it that would be great.
 > > 
 > > Should be converted to the pci_driver API.
 > 
 > No.  It's already using the pci_driver API, but the same device can be
 > handled differently depending on the presence of another one.  Maybe
 > pci_dev_present would fit here.

Maybe, but if this kind of cleanup work is done on this code,
I want it sat in -mm for quite a while. This code has been
quite fragile in the past, and I've lost count how many
times we've broken some Intel i8xx variant inadvertantly.

The fragility is a good indicator however to just how crap
that code actually is, and was one of my motivations for
moving the EM64T stuff to the -mch driver.

		Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/