Re: [PATCH] i386 CPU hotplug updated for -mm

From: Pavel Machek
Date: Mon Oct 18 2004 - 10:17:21 EST


Hi!


> +#ifdef CONFIG_HOTPLUG_CPU
> +#include <asm/nmi.h>
> +/* We don't actually take CPU down, just spin without interrupts. */
> +static inline void play_dead(void)
> +{
> + /* Ack it */
> + __get_cpu_var(cpu_state) = CPU_DEAD;
> +
> + /* We shouldn't have to disable interrupts while dead, but
> + * some interrupts just don't seem to go away, and this makes
> + * it "work" for testing purposes. */
> + /* Death loop */
> + while (__get_cpu_var(cpu_state) != CPU_UP_PREPARE)
> + cpu_relax();
> +
> + local_irq_disable();
> + __flush_tlb_all();
> + cpu_set(smp_processor_id(), cpu_online_map);
> + enable_APIC_timer();
> + local_irq_enable();
> +}
> +#else

Having real implementation of this one would be very welcome for
suspend-to-{RAM,disk} on smp machines....

Are there really no i386 machines whose hardware supports hotplug?

Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/