Re: [2.6] smbfs & "du" illness

[Jeremy Allison]

On Sat, Sep 25, 2004 at 12:16:24PM -0700, Linus Torvalds wrote:
> 
> 
> On Sat, 25 Sep 2004, Jeremy Allison wrote:
> > 
> > To recap, if we have st_blocks from the filesystem we use it
> > and send the value scaled as bytes, if not we send the actual
> > file size there in bytes (as we know any POSIX system has at
> > least that).
> > 
> > Happy ?
> 
> Not really. Where did that 1MB minimum value come from?

A Samba bug for Linux clients. Sending 1mb minimum for Windows
clients causes them to use larger internal buffers and do
larger reads. So making this value 1mb is good for us when
serving Windows clients.

The "blocks used on disk" logic in smbd is one function
called from all the (several :-) different info levels
that return this value. I made this mistake of calling
it for the UNIX info level return also, instead of returning
the real value for UNIX clients (who can handle the truth
rather better than Windows :-).

I'll fix it for the next Samba release. Happy *now* ? :-).

Jeremy.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/