Re: [PATCH Trivial] ppc64: Use STACK_FRAME_OVERHEAD macro in misc.S

From: Paul Mackerras
Date: Thu Sep 09 2004 - 18:41:16 EST


Josh Boyer writes:

> I found a couple places where a hardcoded value for the stack frame was
> used instead of the STACK_FRAME_OVERHEAD macro. The following patch
> fixes that.

Using STACK_FRAME_OVERHEAD here would be purely arbitrary (i.e. the
112 here has no connection with the stack frames established in head.S
and entry.S). This function needs a stack frame and 112 bytes is the
minimum size specified by the ABI. I think it's quite clear as it is.

Paul.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/