Re: [PATCH] cacheline align pagevec structure

[Andrew Morton]

Marcelo Tosatti <marcelo.tosatti@xxxxxxxxxxxx> wrote:
>
> > I think the patch make sense, but I'm very sceptical about the benchmarks
> > ;)
> 
> Why's that? You think changing to the number of pages in the pagevec to "15" instead
> "16" is the cause?

Nope.  I wouldn't have expected to see a significant (or even measurable)
change in performance as a result of this patch.

After all, these structures are always stack-allocated, and top-of-stack is
most always in L1 cache.

I'd suspect that benchmark variability is the cause here.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/