Re: [PATCH]SELinux performance improvement by RCU (Re: RCU issue with SELinux)

[Paul E. McKenney]

On Mon, Aug 30, 2004 at 11:35:19AM -0400, Stephen Smalley wrote:
> On Mon, 2004-08-30 at 07:17, Kaigai Kohei wrote:
> > I fixed the take-3 patch according to your and Paul's suggestions.
> > 
> > The attached take-4 patches replace the avc_lock in security/selinux/avc.c
> > by the lock-less read access with RCU.
> 
> Thanks.  Was there a reason you didn't move the rcu_read_lock call after
> the avc_insert call per the suggestion of Paul McKenney, or was that
> just an oversight?  No need to send a new patch, just ack whether or not
> you meant to switch the order there.

One reason might be because I called it out in the text of my message,
but failed to put it in my patch.  :-/  Of course, if there is some reason
why moving the rcu_read_lock() call is bad, I would like to know for
my own education.

						Thanx, Paul
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/