Re: [PATCH] fix rmmod sbp2 hang in 2.6.7

From: Russell King
Date: Wed Jul 14 2004 - 05:23:02 EST


On Wed, Jul 14, 2004 at 05:29:57PM +0800, Hugang wrote:
> On Wed, 14 Jul 2004 10:24:17 +0100
> Russell King <rmk+lkml@xxxxxxxxxxxxxxxx> wrote:
> | This down+up prevents drivers from being unloaded until there are no
> | references to their struct device_driver. By removing this, you open
> | the very real possibility for an oops to occur.
> Yes, I agree with you. When sbp2 is using the module count is not zero,
> so I can rmmod it, So I think, for sbp2 that's safe, That's true on my
> laptop.

The module count does not cover all cases, especially the case which this
semaphore protects against.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/