Re: [PATCH] Use NULL instead of integer 0 in security/selinux/

From: Linus Torvalds
Date: Sun Jul 11 2004 - 11:15:04 EST




On Sun, 11 Jul 2004, Geert Uytterhoeven wrote:
>
> But why does sparse complain about
>
> p->thread.fs = get_fs().seg;

Sparse bug. Hey, it's not perfect, and this case is actually very easy to
just parse, but harder to build a nice internal representation of it.

In particular, sparse internally really _should_ re-write the above as

fnret = get_fs();
p->thread.fs = fnret.seg;

since that is what would happen in real life, but since it never came up
in early testing, I didn't ever really get around to doing it that way.
Oh, well.

So please don't take _all_ sparse warnings too seriously. Some of them
literally are still due to sparse limitations. I'm happy to say that they
are fairly few these days.

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/