Re: [PATCH] preset loops_per_jiffy for faster booting

[Todd Poynor]

Adam Kropelin wrote:

> +	if (preset_lpj) {
> +		loops_per_jiffy = preset_lpj;
> +		printk("Calibrating delay loop (skipped)... ");

Suggest a "\n" at the end of that.  Maybe add the precomputed value to 
help bring incorrect presets to someone's attention, something like:

+		printk("BogoMIPS preset to %lu.%02lu\n",
+			loops_per_jiffy/(500000/HZ),
+			(loops_per_jiffy/(5000/HZ)) % 100);

> + If unsure, set this to 0. An incorrect value will cause delays in
> + the kernel to be incorrect.  Although unlikely, in the extreme case
> + this might damage your hardware.

I suppose it may result in unpredictable I/O errors, in case we want to 
warn against that.


--
Todd Poynor
MontaVista Software
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/