Re: GCC 3.4 and broken inlining.

From: Adrian Bunk
Date: Fri Jul 09 2004 - 20:25:41 EST


On Fri, Jul 09, 2004 at 08:24:03AM +0200, Arjan van de Ven wrote:
> On Fri, Jul 09, 2004 at 08:08:21AM +1000, Nigel Cunningham wrote:
> > Hi.
> >
> > On Fri, 2004-07-09 at 07:09, Arjan van de Ven wrote:
> > > the problem I've seen is that when gcc doesn't honor normal inline, it will
> > > often error out if you always inline....
> > > I'm open to removing the < 4 but as jakub said, 3.4 is quit good at honoring
> > > normal inline, and when it doesn't there often is a strong reason.....
> >
> > I'm busy for the next couple of days, but if you want, I'll make
> > allyesconfig next week and go through fixing the compilation errors so
> > that the < 4 can be removed. Rearranging code so that inline functions
> > are defined before they're called or not declared inline if they can't
> > always be inlined seems to me to be the right thing to do. (Feel free to
> > say I'm wrong!).
>
> one thing to note is that you also need to monitor stack usage then :)
> inlining somewhat blows up stack usage so do monitor it...

How could inlining increase stack usage?

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/