Con Kolivas wrote:Nick Piggin writes:
A few comments. I think making swappiness depend on the amount of
swap you have used is not a good idea. I might be wrong though, but
generally you should only make something *more* complex if you have
a good rationale and good numbers (you have the later, Andrew might
consider this enough). I especially don't like this sort of temporal
dependancy either, because it makes things much harder to reproduce
and think through.
Noted. The amount of swap hardly has any effect on the swappiness except when you're close to OOMing and it is harder to OOM with this in place.
OK that's easy then. The OOM algorithm can be changed if it is
OOMing too easily.
Secondly, can you please not mess with the exported sysctl. If you
think your "autoswappiness" calculation is better than the current
swappiness one, just completely replace it. Bonus points if you can
retain the swappiness knob in some capacity.
I agree and would like them all removed, but people just love to leave the knobs in place. While I dont think the knobs should still be there either, I'm not reluctant to leave something that innocuous if the users want them.
Well, get rid of the auto-tuning thing to start with, and merge
it into the swappiness calculation..
Regarding all these knobs, the main thing you want to avoid is
having loads of them because you can't find acceptable defaults.
I think "swappiness" is in the category of a good sysctl: it is
simple, meaningful to the admin, works, etc.
It has proven somewhat useful in testing ("set it to blah and see
if it still happens"). Or for people who know what they are doing.
Attachment:
pgp00000.pgp
Description: PGP signature