Re: [PATCH] PPC64: lockfix for rtas error log

[Olof Johansson]

Benjamin Herrenschmidt wrote:
> > So instead, the problem can be easily
> > avoided by not using a global buffer.  The code below mallocs/frees.
> > Its not perf-critcal, so I don't mind malloc overhead.  Would this
> > work for you?  Patch attached below.
>
>
> I prefer that, but couldn't we move the kmalloc outside of the spinlock
> and so use GFP_KERNEL instead ?

Isn't the global buffer used since it's in BSS, and as such, in low 
memory, guaranteed to be below 4GB? RTAS has limitations that restricts 
any passed-in buffers to be addressable as 32-bit real mode pointers, right?


-Olof
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/