Re: [PATCH] PPC64: lockfix for rtas error log

[Benjamin Herrenschmidt]

> Well, the problem was that there is no lock that is protecting the
> use of the single, global buffer.  Adding yet another lock is bad;
> it makes hunting for deadlocks that much more tedious and difficult;
> already, finding deadlocks is error-prone, and subject to bit-rot as
> future hackers update the code.  So instead, the problem can be easily
> avoided by not using a global buffer.  The code below mallocs/frees.
> Its not perf-critcal, so I don't mind malloc overhead.  Would this
> work for you?  Patch attached below.

I prefer that, but couldn't we move the kmalloc outside of the spinlock
and so use GFP_KERNEL instead ?

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/