Re: [PATCH] s390 (8/10): zfcp fixes.

From: Greg KH
Date: Fri Mar 12 2004 - 20:48:25 EST

On Fri, Mar 12, 2004 at 09:29:16PM +0100, Martin Schwidefsky wrote:
> Hi Christoph,
> > > - Replace release function for device structures by kfree. Move struct
> > > device to the start of struct zfcp_port/zfcp_unit to make it work.
> >
> > That's ugly as hell. Actually even more ugly. It's not that ->release
> > is such a performance critical path that you absolutely need to avoid one
> > level of function calls. So please put a simple wrapper back instead of
> > the horrible casts and suddenly the silly placement restrictions are gone,
> > too.
> That it's ugly is true. But what's important is that it is required to get
> module ref-counting right. The release function is called after the last
> module_put has been done.

Huh? Is the scsi reference counting logic that messed up? If so, it
needs to be fixed.

And if so, why does it not show up with all of the other scsi drivers?


greg k-h
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at