Re: [PATCH] s390 (8/10): zfcp fixes.

[Martin Schwidefsky]

Hi Christoph,

> >  - Replace release function for device structures by kfree. Move struct
> >    device to the start of struct zfcp_port/zfcp_unit to make it work.
>
> That's ugly as hell.  Actually even more ugly.  It's not that ->release
> is such a performance critical path that you absolutely need to avoid one
> level of function calls.  So please put a simple wrapper back instead of
> the horrible casts and suddenly the silly placement restrictions are gone,
> too.

That it's ugly is true. But what's important is that it is required to get
module ref-counting right. The release function is called after the last
module_put has been done.

blue skies,
   Martin

Linux/390 Design & Development, IBM Deutschland Entwicklung GmbH
Schönaicherstr. 220, D-71032 Böblingen, Telefon: 49 - (0)7031 - 16-2247
E-Mail: schwidefsky@xxxxxxxxxx


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/