Re: [PATCH] s390 (8/10): zfcp fixes.

[Christoph Hellwig]

On Fri, Mar 12, 2004 at 08:38:16PM +0100, Martin Schwidefsky wrote:
>  - Replace release function for device structures by kfree. Move struct
>    device to the start of struct zfcp_port/zfcp_unit to make it work.

That's ugly as hell.  Actually even more ugly.  It's not that ->release
is such a performance critical path that you absolutely need to avoid one
level of function calls.  So please put a simple wrapper back instead of
the horrible casts and suddenly the silly placement restrictions are gone,
too.

And *please* send any scsi driver changes to linux-scsi@xxxxxxxxxxxxxxxx

While we're at it, what's the reason zfcp isn't in drivers/scsi/?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/