Re: 2.6.4-rc2-mm1: IPMI_SMB doesnt compile

From: Corey Minyard
Date: Wed Mar 10 2004 - 14:16:03 EST

Adrian Bunk wrote:

The patch to i2c-core.c is strange:

--- linux-v31/drivers/i2c/i2c-core.c 2004-02-19 19:31:07.000000000 -0600
+++ linux/drivers/i2c/i2c-core.c 2004-03-10 09:48:08.000000000 -0600
@@ -1256,6 +1256,12 @@
return (func & adap_func) == func;

+int i2c_spin_delay;
+void i2c_set_spin_delay(int val)
+ i2c_spin_delay = val;
@@ -1292,6 +1298,8 @@


MODULE_AUTHOR("Simon G. Vogl <simon@xxxxxxxxxxxxxxxxx>");
MODULE_DESCRIPTION("I2C-Bus main module");

You can either add get/set functions and export them (more an OO paradigm) or export the variable.

If you export the variable, it's quite useless to add such a set function since everyone can set the variable directly.

I think the point is that lower-level drivers need to use this variable (because of its use in the include file), but it's better to set it with a function from external code.

Todd, am I correct here?


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at