On Wed, Mar 03, 2004 at 11:52:47AM +0100, Pavel Machek wrote:I agree, lets force the ";".
Hi!
I would really like to keep this stuff out of kgdb.h since it may be included by the user to pick up the BREAKPOINT() (which, by the way we should standardize as I note that here it has () while not on the current x86).
It's BREAKPOINT() everywhere:
$ grep BREAKPOINT include/asm-*/kgdb.h
include/asm-i386/kgdb.h:#define BREAKPOINT() asm(" int $3");
include/asm-ppc/kgdb.h:#define BREAKPOINT() asm(".long 0x7d821008") /* twge r2, r2 */
include/asm-x86_64/kgdb.h:#define BREAKPOINT() asm(" int $3");
Notice how it ends with ';' on everything but ppc. Perhaps it needs do
{ } while (0) wrapping?
... not that PPC works right now :) But yes, you're right.