Re: Radeon Framebuffer Driver in 2.6.3?

[James Simmons]

> > Just a couple of things. The idea of adding another field to 
> > con_blank bothers me. I think the better approach is to add more flags.
> 
> Linus proposed the additional parameter approach ;

Still don't care for it. 

> > > -	if (memcmp(&info->var, var, sizeof(struct fb_var_screeninfo))) {
> > > +	if ((var->activate & FB_ACTIVATE_FORCE) ||
> > > +	    memcmp(&info->var, var, sizeof(struct fb_var_screeninfo))) {
> > >  		if (!info->fbops->fb_check_var) {
> > >  			*var = info->var;
> > >  			return 0;
> > 
> > Ug!!! Another flag. How about instead in fbcon.c we call set_par directly 
> > instead of messing with fb_set_var. 
> 
> Because fb_set_par is the proper interface, I want to get rid of all
> the direct calls to the fbdev made by fbcon in the end. Calling
> set_par directly will also skip the notification of the clients,
> which may be just what we want for fbcon and harmful the day some
> other client relies on that mecanism (and I already have one example
> on ppc).

Rememeber we have to modify every driver then to support FB_ACTIVATE_FORCE.
You have to ask yourself what do you want to do exactly? 


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/