Re: [PATCH][1/6] A different KGDB stub

[Tom Rini]

On Tue, Feb 17, 2004 at 04:33:12PM -0800, Andrew Morton wrote:

> Tom Rini <trini@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > By my read of Andi's email, the kern_do_schedule() gunk is "I really
> > don't like this change. It is completely useless because you can get the
> > pt_regs as well from the stack.  Please don't add it. George's stub also
> > didn't need it."
> > 
> > But I don't see how it does.  But I'll look again tomorrow.
> 
> OK, thanks.  That would be appreciated, if only because the sched.c and
> entry.S changes have caused significant patch-conflict hassles in the past,
> and they're pretty ugly.

Two things:
- I've looked harder, and I still don't see some pre-exiting get pt_regs
  off the stack func / macro.  But it would probably be generally useful
  since it _looks_ like there's few places it could be used.  Or maybe I
  misread something and just missed it (not being an i386 person, it's
  possible :))
- The current plan for KGDB stuffs is to punt on the thread stuffs for
  now anyhow, so we can look at this again later.

-- 
Tom Rini
http://gate.crashing.org/~trini/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/