Re: PATCH, RFC: 2.6 Documentation/Codingstyle

[Valdis . Kletnieks]

On Fri, 13 Feb 2004 17:38:15 +0100, "Angelo Dell'Aera" said:
> -----BEGIN PGP SIGNED MESSAGE-----

First, you said:

> >> which is not you. A simple use of inline functions and a previous thinking
 
> >> about what you're going to write could easily solve all problems. 

And now:

> I'm not saying "just inline anything and you'll solve problems". I'm saying
> that if your design is well done and you consider the availability of the
> inlines your code will surely be better. And maybe you wouldn't need to discu
ss
> why the current limit is 80...

I didn't claim it didn't help.  I objected to your claim that it would
"easily solve all problems".  It help, but isn't a cure-all.

(Sorry, I'm just touchy - after a quarter of a century of hearing "fixes
everything" claims for everything from "structured programming" to "extreme
programming", I tend to take extreme objection.. :)

> You could create a lot of examples where it's difficult to create an
> inline.. but they're just examples! There are a lot of ways for writing
> the same code and maybe if your example was taken from a real-life code
> it could be written in a different and more easy-to-read manner. 

4 tabs:
[/usr/src/linux-2.6.3-rc2-mm1]2 find . -name '*.[ch]' | xargs grep '\t\t\t\tgoto' | wc -l
    827

And 5:
[/usr/src/linux-2.6.3-rc2-mm1]2 find . -name '*.[ch]' | xargs grep '\t\t\t\t\tgoto' | wc -l
    183

Feel free to start fixing. :)

Attachment: pgp00000.pgp
Description: PGP signature