Re: Suspected bug infilesystems (UFS,ADFS,BEFS,BFS,ReiserFS) relatedto sector_t being unsigned, advice requested

[Jesper Juhl]

On Wed, 7 Jan 2004, Oleg Drokin wrote:

> Hello!
>
> On Wed, Jan 07, 2004 at 02:00:35PM +0300, Hans Reiser wrote:
>
> > >>can we get gcc to issue us a warning?  there might be other stuff
> > >>lurking around also....
> > >If you add -W switch to CFLAGS, you'd get A LOT of more warnings.
> > >Also just reading manpage on gcc around description of that flag will
> > >give you a list of options to individually turn on certain check types.
> > >Also gcc 3.3 have this sort of " unsigned < 0 | unsigned > 0" checks on by
> > >default, I think.
> > Sigh, this means that not one member of our team bothered to compile
> > with -W and cleanup things that were found?  Sad.  This is what happens
>
> Well, I was doing these sorts of stuff and cleaning all stuff that I thought
> was important enough.
>

This is what I'm currently doing with all new -mm kernels. There's a lot
of signed vs unsigned comparison all over the kernel as well as unsigned
values being compared to negative values, missing initializers, and a lot
of other minor stuff.
I'm slowly trying to clean up what I find...
I'm most likely not going to be able to clean it /all/ up, and it's a slow
process for me, but I'll be posting patches whenever I think I've got
something cleaned up correctly.


- Jesper Juhl

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/