Re: [PATCH] amd76x_pm on 2.6.0-test9 cleanup

From: Pasi Savolainen
Date: Fri Nov 14 2003 - 06:57:57 EST


* Tony Lindgren <tony@xxxxxxxxxxx> [031104 23:00]:
> * Pasi Savolainen <pasi.savolainen@xxxxxx> [031104 12:21]:
> > * Tony Lindgren <tony@xxxxxxxxxxx> [031104 21:24]:
> > > * john stultz <johnstul@xxxxxxxxxx> [031104 10:43]:
> > > > On Mon, 2003-11-03 at 16:22, Tony Lindgren wrote:
> > > > I've received some reports that this patch causes time problems.
> > > >
> > > > Have those issues been looked into further, or addressed?
> > >
> > > I've heard of timing problems if it's compiled in, but supposedly they don't
> > > happen when loaded as module.
> >
> > Not happening since 2.6.0-test9. Don't know what really fixed it, but
> > they're just not there anymore.
>
> Weird, John, is this true on your S2460 also?

Well I'll be damned. It took 18 days to show up. Though I've been
riding this baby heavy for about a week.
So I've gettimeofday() jumping backwards again.

# uname -a
Linux tienel 2.6.0-test9 #2 SMP Sun Oct 26 14:35:02 EET 2003 i686 GNU/Linux


It's this test I'm running (snipped from previous TSC desych
-conversation):

- -
#include <stdio.h>
#include <sys/types.h>
#include <sys/time.h>

int main( void )
{
int i = 0;

while( 1 )
{
struct timeval start;
struct timeval stop;
struct timeval diff;
int rc1;
int rc2;

if( i++ % 1000000 == 0 )
printf( "% 12d: Iterations so far\n", i );

rc1 = gettimeofday( &start, 0 );
rc2 = gettimeofday( &stop, 0 );
timersub( &stop, &start, &diff );

if( rc1 < 0 || rc2 < 0 )
printf( " %12d: rc1=%d rc2=%d. Failure!\n",
i,
rc1,
rc2
);

if( diff.tv_sec >= 0 && diff.tv_usec >= 0 )
continue;

printf( "% 12d: Time went backwards: %d:%06d\n",
i,
diff.tv_sec,
diff.tv_usec
);

}
}
- -

--
Psi -- <http://www.iki.fi/pasi.savolainen>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/