2.6.0-test7 BLK_DEV_FD dependence on ISA breakage

[Mikael Pettersson]

As found in ChangeLog-2.6.0-test7:
><akpm@xxxxxxxx>
>	[PATCH] Disable floppy and the related ioctl32s on some platforms
>	
>	From: Arun Sharma <arun.sharma@xxxxxxxxx>
>	
>	Based on some earlier discussion:
>	
>	http://marc.theaimsgroup.com/?t=106015010700002&r=1&w=2
>	
>	here's a new patch that attempts to disable BLK_DEV_FD on platforms which
>	don't support it.

This patch

--- a/drivers/block/Kconfig	Wed Oct  8 12:24:56 2003
+++ b/drivers/block/Kconfig	Wed Oct  8 12:24:56 2003
@@ -6,7 +6,7 @@
 
 config BLK_DEV_FD
 	tristate "Normal floppy disk support"
-	depends on !X86_PC9800 && !ARCH_S390
+	depends on ISA || M68 || SPARC64
 	---help---
 	  If you want to use the floppy disk drive(s) of your PC under Linux,
 	  say Y. Information about this driver, especially important for IBM

is broken. The help text and de facto definition of CONFIG_ISA only
refers to devices in ISA _slots_. Since the FDC is not such a device,
this patch reinterprets CONFIG_ISA to mean any device which is
accessed via in/out to the low I/O port range.

Well in that case I guess !CONFIG_ISA should also disable keyboards,
serial ports, dma controllers, timers, etc.

IA64 folks may not want to be asked about BLK_DEV_FD, but this patch
now forces me to set CONFIG_ISA in my ISA-slot-free machines, which
also adds a lot of new config options I don't want.

/Mikael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/