Re: [PATCH] s390 (2/19): common i/o layer.

From: Christoph Hellwig
Date: Fri Sep 26 2003 - 03:03:35 EST


> +static inline void
> +__ccwgroup_remove_symlinks(struct ccwgroup_device *gdev)
> +{
> + int i;
> + char str[8];
> +
> + for (i = 0; i < gdev->count; i++) {
> + sprintf(str, "cdev%d", i);
> + sysfs_remove_link(&gdev->dev.kobj, str);
> + /* Hack: Make sure we act on still valid subdirs. */
> + if (atomic_read(&gdev->cdev[i]->dev.kobj.dentry->d_count))
> + sysfs_remove_link(&gdev->cdev[i]->dev.kobj,
> + "group_device");
> + }

This looks like you have a bad refcounting problem somewhere. I'd rather
see it fixed than hacked around..


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/