Re: log-buf-len dynamic

[Andrew Morton]

Andrea Arcangeli <andrea@xxxxxxx> wrote:
>
> I don't think we can merge this in 2.4 but it looks good for 2.6.

I think so: doing it via a __setup parameter is much smarter than requiring
a rebuild.

> +static int __init log_buf_len_setup(char *str)
> +{
> +	unsigned long size = simple_strtoul(str, &str, 0);
> +
> +	if (size & (size-1))
> +		printk("log_buf_len: invalid size - needs a power of two\n");

You need to either panic or return here.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/