Re: A couple of 2.4.23-pre4 VM nits

From: Shantanu Goel
Date: Sun Sep 21 2003 - 09:53:07 EST


I just realized the original code had one desirable
behaviour that my patch is missing, namely, it
reclaimed memory from dcache/inode every time swap_out
is called. Please use the attached patch that
restores the original behaviour. Otherwise, if the
interval is very long, no reclamation will happen
until swap_out() fails which in the common case is
unlikely.

Thanks,
Shantanu

--- Andrea Arcangeli <andrea@xxxxxxx> wrote:
> On Sat, Sep 20, 2003 at 10:32:09PM -0700, Shantanu
> Goel wrote:
> > Agreed on all counts. I just blindly copied the
> > max_scan decrement from 2.4.22. Even there your
> > suggestion would make sense. Attached is a new
> patch
> > which adds support for vm_vfs_scan_interval sysctl
> and
> > also fixes the location of max_scan decrement.
>
> this patch looks fine to me thanks. Marcelo, feel
> free to merge this one
> instead of my one liner fix.
>
> Andrea - If you prefer relying on open source
> software, check these links:
>
>
rsync.kernel.org::pub/scm/linux/kernel/bkcvs/linux-2.[45]/
> http://www.cobite.com/cvsps/
> svn://svn.kernel.org/linux-2.[46]/trunk

__________________________________
Do you Yahoo!?
Yahoo! SiteBuilder - Free, easy-to-use web site design software
http://sitebuilder.yahoo.com

Attachment: vfs-interval2.patch
Description: vfs-interval2.patch