Re: [PCMCIA] Xircom nic hang on boot since cs.c race condition patch

[Valdis . Kletnieks]

On Wed, 17 Sep 2003 22:33:36 BST, Russell King said:
> On Wed, Sep 17, 2003 at 02:44:06PM -0400, Sean Estabrooks wrote:
> > [PCMCIA] Fix race condition causing cards to be incorrectly recognised
> > 
> > This patch that went into test5 causes my Toshiba laptop with Xircom 
> > pcmcia nic to freeze on boot at "Socket status: 30000020".  
> 
> Unfortunately this patch does two things:
> 
> (a) it fixes the problem with PCMCIA cards not being recognised on boot.
> (b) it introduces a deadlock between the PCMCIA layer and the driver
>     model.

OK... so what's different about Sean's Toshiba and my Dell (or alternatively,
the fact we both have Xircom cards) that the *old* code worked just fine?

Is it the fact that it's a multi-function card?

lspci -v says:
03:00.0 Ethernet controller: Xircom Cardbus Ethernet 10/100 (rev 03)
        Subsystem: Xircom Cardbus Ethernet 10/100
        Flags: bus master, medium devsel, latency 64, IRQ 9
        I/O ports at 1000 [size=128]
        Memory at 10800000 (32-bit, non-prefetchable) [size=2K]
        Memory at 10800800 (32-bit, non-prefetchable) [size=2K]
        Expansion ROM at 10400000 [disabled] [size=16K]
        Capabilities: [dc] Power Management version 1

03:00.1 Serial controller: Xircom Cardbus Ethernet + 56k Modem (rev 03) (prog-if 02 [16550])
        Subsystem: Xircom CBEM56G-100 Ethernet + 56k Modem
        Flags: medium devsel, IRQ 9
        I/O ports at 1080 [size=8]
        Memory at 10801000 (32-bit, non-prefetchable) [size=2K]
        Memory at 10801800 (32-bit, non-prefetchable) [size=2K]
        Expansion ROM at 10404000 [disabled] [size=16K]
        Capabilities: [dc] Power Management version 1

I could see problems if the serial controller is being added while the ethernet
controller is still getting its act together while holding locks, since it's one
physical card.

I admit not being hot on the programming model  for cardbus, but I'm
quite willing to test patches.. ;)

Attachment: pgp00001.pgp
Description: PGP signature