Re: [PATCH] Athlon/Opteron Prefetch Fix for 2.6.0test5 + numbers

From: Linus Torvalds
Date: Wed Sep 17 2003 - 14:55:49 EST



On Wed, 17 Sep 2003, Nick Piggin wrote:
>
> What is intriguing to me is the "Its only a 2% slowdown of the page
> fault for every cpu other than K[78] for this single workaround. There
> is no point to conditional compilation" attitude some people have.

I wouldn't worry about performance as much as correctness. I'm a lot more
worried about the notion of taking recursive pagefaults than about 2%.

Which means that I think the code should be disabled on non-buggy
hardware. Not becuase of the 2%, but because it just exposes the potential
of new bugs.

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/