Re: Dumb question: BKL on reboot ?

[Andrea Arcangeli]

> >This can't be the lock_kernel, you see, there's no lock_kernel
> >invocation at all in the machine_restart_smp path.
> 
> Oh? sys_reboot() does call lock_kernel(). kernel/sys.c:303.

yes, I know, I meant that it's not spinning on the lock, sys_reboot gets
through lock_kernel w/o problems. It gets the lock successfully.

> Agreed, this smp_processor_id() == 0 thing is interesting. I'll try you 
> suggestion and see how far I'll progress.

thanks, that's the right fix as far as I can tell and the lock_kernel
would better stay to serialize concurrent sys_reboot.

Andrea
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/