Re: [PATCH] 'noapic' already handled elsewhere

[Jeff Garzik]

Brown, Len wrote:
> Jeff,
> This won't work.
> acpi_boot_init() is called from setup_arch(), which is called from
> start_kernel() _before_ parse_options().  Ie. ACPI needs to consume this
> flag before __setup() is invoked.


Thanks for the correction.  I'll resend the earlier 
s/LOCAL_APIC/IO_APIC/ patch then.

Just found another ACPI bug in 2.6:

> config ACPI_HT
>         bool "ACPI Processor Enumeration for HT"
>         depends on (X86 && X86_LOCAL_APIC)
>         default y
[...]
> config ACPI
>         bool "Full ACPI Support"
>         depends on !X86_VISWS
>         depends on !IA64_HP_SIM
>         depends on IA64 || (X86 && ACPI_HT)


So CONFIG_ACPI is not allowed on uniprocessor anymore, _and_ it requires 
HyperThreading code?  ;-)  No wonder CONFIG_ACPI didn't appear for my 
uniprocessor Pentium3 'make oldconfig'  ;-)

(ACPI requires ACPI_HT, which requires LOCAL_APIC)

Another reason why I was saying that CONFIG_ACPI should be the toplevel 
config option (even if CONFIG_ACPI never actually appears in any code, 
but only in Kconfig)...

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/