RE: [PATCH] 'noapic' already handled elsewhere

[Brown, Len]

Jeff,
This won't work.
acpi_boot_init() is called from setup_arch(), which is called from
start_kernel() _before_ parse_options().  Ie. ACPI needs to consume this
flag before __setup() is invoked.

-Len

> -----Original Message-----
> From: Jeff Garzik [mailto:jgarzik@xxxxxxxxx] 
> Sent: Thursday, August 21, 2003 12:15 PM
> To: torvalds@xxxxxxxx
> Cc: Brown, Len; Grover, Andrew; zwane@xxxxxxxxxxxxx; 
> linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH] 'noapic' already handled elsewhere
> 
> 
> I sent a previous patch to s/LOCAL_APIC/IO_APIC/, as Zwane noticed
> my first patch needed that.  In that patch, I commented __setup()
> would be better.
> 
> Well... line 718 of arch/i386/kernel/io_apic.c _already_ handles this
> case, using __setup() properly.
> 
> Word of warning... patch only compile tested, but seems obvious from
> looking at io_apic.c.
> 
> BTW, why isn't ACPI using __setup() as well?  I don't see that ACPI
> needs to patch arch/i386/kernel/setup.c at all.
> 
> 
> ===== arch/i386/kernel/setup.c 1.94 vs edited =====
> --- 1.94/arch/i386/kernel/setup.c	Thu Aug 21 01:32:04 2003
> +++ edited/arch/i386/kernel/setup.c	Thu Aug 21 12:09:13 2003
> @@ -544,12 +544,6 @@
>  			if (!acpi_force) acpi_disabled = 1;
>  		}
>  
> -#ifdef CONFIG_X86_LOCAL_APIC
> -		/* disable IO-APIC */
> -		else if (!memcmp(from, "noapic", 6)) {
> -			skip_ioapic_setup = 1;
> -		}
> -#endif /* CONFIG_X86_LOCAL_APIC */
>  #endif /* CONFIG_ACPI_BOOT */
>  
>  		/*
> 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/