Re: segfault when unloading module loop in 2.6.0-test3+ck patches

[Andrew Morton]

Peter Osterlund <petero2@xxxxxxxxx> wrote:
>
> (I'm resending this because I previously had sendmail configuration
> problems. Sorry if you receive this message twice.)

I saw it (and the other) the first time, thanks.

> diff -puN drivers/block/loop.c~loop-oops-fix drivers/block/loop.c
> --- linux/drivers/block/loop.c~loop-oops-fix	2003-08-17 19:19:22.000000000 +0200
> +++ linux-petero/drivers/block/loop.c	2003-08-17 20:33:03.000000000 +0200
> @@ -1198,6 +1198,7 @@ int __init loop_init(void)
>  		lo->lo_queue = blk_alloc_queue(GFP_KERNEL);
>  		if (!lo->lo_queue)
>  			goto out_mem4;
> +		init_timer(&lo->lo_queue->unplug_timer);
>  		disks[i]->queue = lo->lo_queue;
>  		init_MUTEX(&lo->lo_ctl_mutex);
>  		init_MUTEX_LOCKED(&lo->lo_sem);

This bit should be done in ll_rw_blk.c somewhere.  Are you sure it is
necessary for loop?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/